Allow a specified address to disable/enable the Exchange #1467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
========================================
Coverage 73.61% 73.61%
========================================
Files 277 277
Lines 7443 7443
Branches 956 662 -294
========================================
Hits 5479 5479
Misses 1852 1852
Partials 112 112
Continue to review full report at Codecov.
|
|
|
||
| // onlyWhenNotFrozen functions can only be called when `frozen` is false, otherwise they are | ||
| // noops. | ||
| modifier onlyWhenNotFrozen() { |
There was a problem hiding this comment.
Is this necessary? I would consider cutting this function and renaming onlyWhenNotFrozenOrThrow to onlyWhenNotFrozen
There was a problem hiding this comment.
Should have cleared this up - this is already looking forward to the next change, where distributeEpochPayments will need to be frozen. By not reverting when that function is frozen, I think we'll be able to contain this temporary change for Baklava to smart contracts.
I could see an argument for reverting being the default semantic, happy to rename this one to onlyWhenNotFrozenNoThrow.
WDYT?
There was a problem hiding this comment.
Are you sure we don't want to revert when we freeze epoch rewards for TGCSO? Reverting would prevent any proof-of-stake action from happening in Finalize, e.g. validator score changes, payments, etc.
|
Did you mean to re-assign to me? edit: Whoops, missed your comment |
* master: (62 commits) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) [Wallet] Improve error handling around account creation and keystore ops (#1497) Add CI test for checking licenses and misc package.json cleanup (#1550) [Wallet] Implement SMS invite on iOS (#1541) CI: brings back to master (#1554) Validators: uses Ethereum address for proof of possession (#1494) Validate Attestation Requests (#1468) Rename hosted node references to forno (#1511) Bump rubyzip from 1.2.3 to 1.3.0 in /packages/mobile (#1508) Added txpool family to geth apis. Sorted geth cmd options (#1462) [Wallet] Fix yarn dev command for running android (#1534) [Wallet] iOS info plist changes and version bump (#1539) ... # Conflicts: # yarn.lock
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
Description
For purposes of Baklava, we might need to periodically turn the Exchange off. This PR adds
freezeandunfreezefunctions to the Exchange, allowing an address specified at migration time (and modifiable viasetFreezer) to disable theexchangefunction.Tested
Unit tests.
Other changes
This PR adds a new helper contract, Freezable, that specifies a
freezeraddress and provides modifiers to disable certain contract functions if the contract becomes "frozen".This is in anticipation of a similar change needed in LockedGold.
Related issues
Backwards compatibility
Not backwards compatible, changes Exchange storage layout.